Repository navigation
fix(plugin): use the SHA-256 empty tree for root commit diffs - #1716
Merged
Merged
Conversation
mldangelo-oai
approved these changes
Oct 19, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Root-commit selection and scan-input generation work for SHA-256 repositories with this change, and SHA-1 behavior is preserved.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For a root commit,
require_diff_targetusesEMPTY_GIT_TREEas the base, which is the SHA-1 empty tree. SHA-256 repos don't have that object, so diff scans of a root commit fail with "unknown revision".Changes
Added
EMPTY_GIT_TREESwith both the SHA-1 and SHA-256 IDs, picked viagit rev-parse --show-object-format. Added a test with a SHA-256 root commit. Same fix as in closed #449, pulled out on its own.Testing
Tests pass.
Risk and rollout
SHA-1 repos get the same base as before. Needs Git 2.25+ for
--show-object-format.Public disclosure review